Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service identity endorsements to historical receipts #3679

Merged
merged 38 commits into from
Mar 28, 2022
Merged

Add service identity endorsements to historical receipts #3679

merged 38 commits into from
Mar 28, 2022

Conversation

wintersteiger
Copy link

Implements #3343

@ghost
Copy link

ghost commented Mar 18, 2022 •
edited by ghost
Loading

cwinter_3343@43793 aka 20220328.16 vs main ewma over 20 builds from 43495 to 43785

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
43495 20220322.14 568.495 9.16235e+07 19949.9 1.58639e+07 5571.51 1.6126e+07 2535.43 1.00967e+07 1618.78 1.63713e+08 2107.5 9.04813e+06 1352.46 9.79149e+07 1879.06 1.08831e+07 17470 906069 1.38014e+06 9.18377e+06 3.58669e+07
43511 20220322.21 564.269 9.16235e+07 19573.5 1.66503e+07 5615.56 1.53396e+07 2510.46 1.00967e+07 1632.86 1.63713e+08 2106.59 9.04813e+06 1443.71 9.66042e+07 2001.94 8.52384e+06 18311.7 886571 1.39641e+06 9.40299e+06 3.63759e+07
43528 20220322.29 564.25 9.16235e+07 19234.3 1.63882e+07 5588.49 1.53396e+07 2534.29 1.00967e+07 1603.23 1.62927e+08 2105.18 9.04813e+06 1392.34 9.73907e+07 1917.76 8.78598e+06 17291.4 901443 1.40591e+06 9.2293e+06 3.65714e+07
43535 20220323.1 592.98 9.16235e+07 19639.8 1.63882e+07 5607.2 1.53396e+07 2471.26 1.00967e+07 1642.49 1.63975e+08 2104.5 9.31027e+06 1452.49 9.81771e+07 1929.71 8.52384e+06 19878.5 896627 1.3626e+06 9.22934e+06 3.58042e+07
43567 20220323.16 563.726 9.16235e+07 19454.3 1.56017e+07 5431.55 1.56017e+07 2535.31 9.83456e+06 1619.49 1.63189e+08 2110.46 9.31027e+06 1427.7 9.79149e+07 1933.42 8.52384e+06 17786 903550 1.38265e+06 9.4334e+06 3.58669e+07
43581 20220323.22 549.853 9.39828e+07 19476.9 1.58639e+07 5601.27 1.56017e+07 2525.46 1.00967e+07 1617.67 1.62927e+08 2183.74 9.04813e+06 1445.61 9.81771e+07 1962.42 8.78598e+06 17250.9 915180 1.36944e+06 9.27112e+06 3.58042e+07
43588 20220323.25 569.738 9.16235e+07 19133.4 1.63882e+07 5532.16 1.53396e+07 2532.46 1.00967e+07 1634.05 1.63189e+08 2109.97 9.31027e+06 1445.26 9.87014e+07 1921.83 8.78598e+06 18822.9 894200 1.40331e+06 9.41168e+06 3.55556e+07
43592 20220324.1 579.027 9.16235e+07 19523 1.58639e+07 5622.87 1.53396e+07 2546.51 1.16696e+07 1644.82 1.63975e+08 2118.63 9.31027e+06 1403.38 9.81771e+07 1963.12 9.04813e+06 17494.8 909488 1.39785e+06 9.03389e+06 3.65708e+07
43611 20220324.10 580.96 9.18856e+07 19040.6 1.71746e+07 5570.63 1.63882e+07 2523.23 1.00967e+07 1628.57 1.63713e+08 2106.58 9.31027e+06 1436.54 9.84392e+07 1966.49 8.78598e+06 21164.6 911637 1.38089e+06 9.38154e+06 3.52496e+07
43626 20220324.17 528.731 9.16235e+07 19398.9 1.58639e+07 5590.08 1.56017e+07 2528.5 1.00967e+07 1579.77 1.62927e+08 2097.77 9.04813e+06 1428.71 9.84392e+07 2008.75 8.52384e+06 19008.9 897419 1.37348e+06 9.25441e+06 3.58669e+07
43646 20220324.26 575.042 9.16235e+07 18095.6 1.58639e+07 5576.22 1.56017e+07 2529.9 1.00967e+07 1601.64 1.6083e+08 2098.85 9.31027e+06 1418.66 9.84392e+07 1965.26 8.78598e+06 17077.9 913221 1.39452e+06 9.41605e+06 3.65708e+07
43662 20220324.33 577.453 9.16235e+07 19372.6 1.63882e+07 5610.66 1.53396e+07 2522.4 1.00967e+07 1605.87 1.61092e+08 2062.39 9.04813e+06 1406.16 9.79149e+07 1971.12 8.78598e+06 18572.3 908803 1.34683e+06 9.25018e+06 3.58669e+07
43666 20220325.1 548.973 9.16235e+07 19650.9 1.6126e+07 5536.95 1.58639e+07 2534.99 1.00967e+07 1645.52 1.63975e+08 2080.68 1.29803e+07 1459.53 9.81771e+07 1965.58 8.78598e+06 19098.1 900491 1.38696e+06 9.17144e+06 3.58042e+07
43684 20220325.8 563.811 9.18856e+07 18968.2 1.66503e+07 5586.79 1.53396e+07 2532.08 1.00967e+07 1623.32 1.61092e+08 2113.91 9.04813e+06 1429.34 9.79149e+07 1856.45 1.03588e+07 19629.3 930400 1.38631e+06 9.50789e+06 3.63766e+07
43702 20220325.16 572.758 9.16235e+07 19497.6 1.58639e+07 5561.61 1.6126e+07 2544.93 1.0621e+07 1628.34 1.63975e+08 2107.95 9.04813e+06 1441.39 9.81771e+07 2012.51 1.0621e+07 22504.8 891476 1.36414e+06 9.25014e+06 3.58669e+07
43712 20220325.20 564.277 9.16235e+07 19267 1.63882e+07 5583.37 1.56017e+07 2523.32 1.00967e+07 1599.36 1.63451e+08 2102.73 9.04813e+06 1426.02 9.76528e+07 1968.7 8.78598e+06 19340.7 884355 1.37671e+06 9.36438e+06 3.62478e+07
43737 20220328.1 561.086 9.16235e+07 19412 1.69124e+07 5642.83 1.53396e+07 2529.83 1.00967e+07 1604.58 1.64237e+08 2108.2 9.04813e+06 1419.35 9.84392e+07 1998.83 1.0621e+07 18535.6 912123 1.36824e+06 9.43774e+06 3.63114e+07
43743 20220328.3 534.654 9.16235e+07 19616.5 1.69124e+07 5490.88 1.56017e+07 2541.03 1.03588e+07 1654.26 1.63189e+08 2113.64 9.04813e+06 1450.75 9.81771e+07 1972.82 8.78598e+06 21719.9 925851 1.40003e+06 9.28369e+06 3.65708e+07
43754 20220328.7 6218.95 8.40213e+07 19157.4 1.56017e+07 5548.48 1.56017e+07 2524.35 1.00967e+07 1610.2 1.63189e+08 2111.61 9.04813e+06 1417.59 9.81771e+07 1916.44 9.04813e+06 17349.3 919700 1.37311e+06 9.1469e+06 3.56788e+07
43785 20220328.14 6180.18 8.3497e+07 19220.3 1.6126e+07 5629.5 1.56017e+07 2529.95 1.00967e+07 1607.5 1.63451e+08 2105.31 9.04813e+06 1425.03 9.73907e+07 1929.28 9.04813e+06 17703.9 928370 1.36614e+06 9.28373e+06 3.64413e+07

cwinter_3343

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
43767 20220328.9 6139.22 8.40213e+07 19248.6 1.58639e+07 5644.96 1.56017e+07 2527.77 1.03588e+07 1639.52 1.645e+08 2114.26 9.31027e+06 1424.78 9.73907e+07 1925.39 8.78598e+06 17313.8 905067 1.37136e+06 9.2335e+06 3.58663e+07
43784 20220328.13 6226.8 8.40213e+07 19533.5 1.58639e+07 5524.75 1.56017e+07 2533.8 1.00967e+07 1601.33 1.63451e+08 2107.5 9.04813e+06 1376.41 9.81771e+07 1964.95 8.78598e+06 19530 924933 1.357e+06 9.3858e+06 3.63121e+07
43790 20220328.15 6218.09 8.3497e+07 19536 1.58639e+07 5499.89 1.53396e+07 2538.73 1.03588e+07 1647.45 1.63975e+08 2177.15 9.04813e+06 1432.32 9.81771e+07 2003 8.78598e+06 21246.3 894396 1.41153e+06 9.05389e+06 3.65062e+07
43793 20220328.16 6264 8.32349e+07 19403.8 1.63882e+07 5552.01 1.53396e+07 2530.96 1.03588e+07 1624.88 1.63451e+08 2113.99 9.04813e+06 1454.97 9.81771e+07 1964.92 8.52384e+06 18935.2 885004 1.3755e+06 9.25018e+06 3.58042e+07

images

@wintersteiger wintersteiger force-pushed the cwinter_3343 branch 2 times, most recently from d91fc0e to 53050f1 Compare March 22, 2022 17:45
@wintersteiger
Copy link
Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wintersteiger
Copy link
Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

wintersteiger
wintersteiger commented Mar 23, 2022
View reviewed changes
@wintersteiger wintersteiger marked this pull request as ready for review March 23, 2022 17:23
@wintersteiger wintersteiger requested a review from a team March 23, 2022 17:23
jumaffre
jumaffre reviewed Mar 24, 2022
View reviewed changes
jumaffre
jumaffre reviewed Mar 24, 2022
View reviewed changes
@wintersteiger wintersteiger force-pushed the cwinter_3343 branch 2 times, most recently from 017e717 to 292589f Compare March 24, 2022 16:28
@wintersteiger wintersteiger force-pushed the cwinter_3343 branch 2 times, most recently from 570150f to 2ed4810 Compare March 25, 2022 14:18
Christoph M. Wintersteiger and others added 25 commits March 28, 2022 13:36
Error instead of ledger walk back into 1.x regions
7b89f06
Keep OpenSSL service endorsement checks
f80e63e
Add note about issuer-signed CSRs
1c1e7cf
Add certifiate signer enum
5a1bf6e
-debug +formatting
ec627e8
Update expired test ledger to new service table entries
ee207e8
Docs and moved endorsements checks to fit in better with docs
dce7dfe
Formatting
ffef4cc
Get network identity subsystem more gracefully
f143691
Add ccf::historical::adapter_v3
5df1331
Fix for tests that don't install the network identity subsystem
db78e10
Formatting
2fff035
Fix network identity subsystem problems and make it private
8aac04f
Formatting
2b7afb1
Formatting
9f45e47
Remove leftover endorsement check flag
4371399
Trigger daily
9f46c00
Allow LTS compat test to skip endorsement checks
83223e9
Fix
775e208
Better error message
ce03fad
Soft error
5b0a2ab
Catch 1.x errors
1adf228
@achamayou
Update CHANGELOG.md
87188b0 
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
Nicer or []
87f9cf5
No errors for missing endorsements
5d56c6a
@achamayou achamayou merged commit c856048 into microsoft:main Mar 28, 2022
@wintersteiger wintersteiger deleted the cwinter_3343 branch March 28, 2022 14:34
@wintersteiger wintersteiger mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

@eddyashton eddyashton eddyashton left review comments

@jumaffre jumaffre jumaffre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wintersteiger @achamayou @eddyashton @jumaffre